Skip to content
This repository has been archived by the owner on Dec 18, 2023. It is now read-only.

Point stat choice #1819

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Point stat choice #1819

wants to merge 1 commit into from

Conversation

ndmlny-qs
Copy link
Contributor

Resolves #1817

Motivation

Allow a user to select which point statistic they want displayed in the Marginal 1D tool: mean or median.

Changes proposed

  • Added method to calculate the median of an array in JavaScript.
  • Updated the Marginal 1D tool to use the new method.
  • Updated the Marginal 1D interfaces to include a new widget component.
  • Updated the Python side of the tool to render the new widget.
  • Updated Python TypedDict objects to include docstrings for inclusion in the documentation in the future.
  • Updated the coin flipping tutorial to use the new point statistic button.

Test Plan

  • Updated the coin flipping tutorial, and visually inspected the tool worked.
  • Built the documentation locally for testing the new docstrings in Sphinx.
  • Built the Docusaurus documentation locally to ensure the new widgets worked.
new-widget-check.webm

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • The title of my pull request is a short description of the requested changes.

@ndmlny-qs
Point stat choice
4dc4905 
- Added method to calculate the median of an array in JavaScript.
- Updated the Marginal 1D tool to use the new method.
- Updated the Marginal 1D interfaces to include a new widget component.
- Updated the Python side of the tool to render the new widget.
- Updated Python `TypedDict` objects to include `docstrings` for
  inclusion in the documentation in the future.
- Updated the coin flipping tutorial to use the new point statistic
  button.

Resolves #1817
@ndmlny-qs ndmlny-qs added the enhancement New feature or request label Nov 7, 2022
@ndmlny-qs ndmlny-qs self-assigned this Nov 7, 2022
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 7, 2022
@ndmlny-qs ndmlny-qs mentioned this pull request Nov 7, 2022
Open
@ndmlny-qs
Copy link
Contributor Author

add the Continuous Ranked Probability Score stat as well

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@horizon-blue horizon-blue Awaiting requested review from horizon-blue

At least 1 approving review is required to merge this pull request.

Assignees

@ndmlny-qs ndmlny-qs

Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Marginal point statistic choice
2 participants
@ndmlny-qs @facebook-github-bot