New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LICENSE file #2200

Closed

keskival opened this issue Oct 27, 2020 · 0 comments

keskival commented Oct 27, 2020 •

edited

The Apache LICENSE file in this repository has the copyright holder and year marked up into the Appendix with the example boilerplate text:
https://github.com/facebookresearch/detectron2/blob/master/LICENSE#L189

This boilerplate should be in principle left as such, as seen in this representative project:
https://github.com/apache/flink/blob/master/LICENSE#L189

The copyright holder should be in the NOTICE file as follows:
https://github.com/apache/flink/blob/master/NOTICE#L2

Also, the copyright year should probably be updated to 2020, and "-present" removed as it doesn't have a legal meaning.

Also, all the file headers say "All rights reserved", which is in conflict with the implied permissive license. Those should be removed.
https://github.com/facebookresearch/detectron2/blob/master/detectron2/layers/aspp.py#L1

facebook-github-bot closed this as completed in

60d7a1f

github-actions bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.