Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect reference to CDANN paper in Readme #42

Closed
divyat09 opened this issue Feb 4, 2021 · 0 comments
Closed

Incorrect reference to CDANN paper in Readme #42

divyat09 opened this issue Feb 4, 2021 · 0 comments

Comments

@divyat09
Copy link

divyat09 commented Feb 4, 2021

I suppose the reference to the CDANN paper in Readme is wrong. It points to the following paper (https://arxiv.org/abs/1807.08479), which actually uses MMD in their method, and not domain discriminators that are used in the implementation of CDANN in DomainBed (code).

I think the correct reference to the approach CDANN should be the following paper, which uses domain discriminators.

Ya Li, Xinmei Tian, Mingming Gong, Yajing Liu, Tongliang Liu, Kun Zhang, and Dacheng Tao. Deep domain generalization via conditional invariant adversarial networks.ECCV, 2018d (Link).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants