Evaluation video overwritten

[medric49]

I have noticed, in this line when you are saving evaluation episodes, that you are actually overwriting previous evaluation videos of the same global frame when num_eval_episodes > 1.

            self.video_recorder.save(f'{self.global_frame}.mp4')

The attribute self.global_frame doesn't change during the self.cfg.num_eval_episodes evaluations in the loop.

I would propose this line instead

            self.video_recorder.save(f'{self.global_frame}_{episode}.mp4')

or other things like that.

[medric49]

Finally, I understood what you did with this line

            self.video_recorder.init(self.eval_env, enabled=(episode == 0))

You record only the first evaluation episode.

Is there any reason?

[denisyarats]

Hi, there is no overwrite, since only the first episode is being recorded. If you need to save videos for more episodes you can change it locally.