This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Parallelize ensemble of Q functions into a single model #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
Thanks, will run tests to make sure that it doesn't affect performance. |
|
I run speed comparison on the cluster with V100 and it doesn't seem improving speed consistently. So maybe for now let's hold off with this PR to preserve simplicity.
|
|
Ah, that's interesting! I observed the speedup on a Titan XP on my home machine, I guess different hardware configurations have different bottlenecks impacting training speed ^^ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parallelizing yields a 5-10% speedup on my machine with standard batch size and network width and should not affect any of the functionality. This change should also enable to trivially and efficiently scale up to larger number Q-functions.