Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong device in average_metrics function #34

Open
AndreyBocharnikov opened this issue Feb 10, 2023 · 1 comment
Open

Wrong device in average_metrics function #34

AndreyBocharnikov opened this issue Feb 10, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@AndreyBocharnikov
Copy link

馃悰 Bug Report

Since average_metrics function is being called from backward that should be called from every gpu, the devise that is being created here should be equal to the current rank, otherwise torch.distributed.all_reduce will be stucked forever.

@AndreyBocharnikov AndreyBocharnikov added the bug Something isn't working label Feb 10, 2023
@adefossez
Copy link
Contributor

We use Dora for all of our experiments which typically calls torch.cuda.set_device at the beginning of the training with the proper device. That allows to use 'cuda' everywhere after without worrying about the rank of the gpu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants