Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[perf] PyTorch AMP reverts the grads to fp32, meaning that reduce calls are overweight #402

Closed
blefaudeux opened this issue Feb 18, 2021 · 0 comments 路 Fixed by #411
Closed
Assignees
Labels
enhancement New feature or request

Comments

@blefaudeux
Copy link
Contributor

馃殌 Feature

Either through torch amp or via a postfix .half() cast (not too nice), make sure that we don't reduce fp32 grads when they were actually computed on fp16..

Motivation

The gradient size are double what they should be if torch AMP is being used, which can be a bottleneck depending on internode coms

Pitch

free speed

Alternatives

Not doing anything, this does not affect correctness

Additional context

@blefaudeux blefaudeux self-assigned this Feb 18, 2021
@blefaudeux blefaudeux added the enhancement New feature or request label Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant