Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Assert with an understandable error message if there are not enough parameters in the model given the world size #405

Closed
blefaudeux opened this issue Feb 19, 2021 · 1 comment 路 Fixed by #406
Closed

[fix] Assert with an understandable error message if there are not enough parameters in the model given the world size #405

blefaudeux opened this issue Feb 19, 2021 · 1 comment 路 Fixed by #406

Comments

@blefaudeux
Copy link
Contributor

馃殌 Feature

Assert if shards are empty, explain what the issue is

Motivation

Can happen in dummy tests and be confusing #397

Pitch

Trivial catch, helps people

Alternatives

Bump into the same issue later

Additional context
@blefaudeux
Copy link
Contributor Author

cc @kamo-naoyuki

@blefaudeux blefaudeux mentioned this issue Feb 19, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[fix][OSS] adding an assert for empty shards + corresponding unit test facebookresearch/fairscale
1 participant
@blefaudeux