fixing import bug and gating by torch version #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D31706627 |
HDCharles
added a commit
to HDCharles/fvcore
that referenced
this pull request
Oct 16, 2021
Summary: Pull Request resolved: facebookresearch#88 caused facebookresearch#87 when trying to migrate fvcore to ao, this fixes by gating before importing Reviewed By: ppwwyyxx Differential Revision: D31706627 fbshipit-source-id: 4a7844b19d001971ef6a25cf4f573946f1ae5ca9
|
This pull request was exported from Phabricator. Differential Revision: D31706627 |
HDCharles
force-pushed
the
export-D31706627
branch
from
21171ec
to
a5a58d8
Compare
Summary: Pull Request resolved: facebookresearch#88 caused facebookresearch#87 when trying to migrate fvcore to ao, this fixes by gating before importing Reviewed By: ppwwyyxx Differential Revision: D31706627 fbshipit-source-id: 0a50edcb2d6ff37c861525048cb73ef1c4137861
HDCharles
force-pushed
the
export-D31706627
branch
from
a5a58d8
to
84a5c70
Compare
|
This pull request was exported from Phabricator. Differential Revision: D31706627 |
|
This pull request has been merged in 2454c6e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: caused #87 when trying to migrate fvcore to ao, this fixes by gating before importing
Differential Revision: D31706627