Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all interfaces from List[float] to np.array(float) #84

Open
mathfac opened this issue May 15, 2019 · 0 comments
Open

Move all interfaces from List[float] to np.array(float) #84

mathfac opened this issue May 15, 2019 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mathfac
Copy link
Contributor

mathfac commented May 15, 2019

Motivation

While to support more general API and be json friendly we designed agent position and state as List[float] np.array(float) is more efficient in terms of communication between HSIM (Habitat Simulator) as well as is more native for PyTorch usage.

Steps for implementation:

  1. Find List[float] in core interfaces and check if it's convenient to switch to np.array(float) and do the switch. Switch in core implementation classes as well.
  2. Update Dataset reading and writing code to do conversion between List[float] and np.array(float), as in np.array isn't json serializable.
  3. Run mypy to check API are consistent and pytest.
@mathfac mathfac added the enhancement New feature or request label May 15, 2019
@mathfac mathfac added the good first issue Good for newcomers label Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant