Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unknown CMake command "add_compile_definitions". #137

Closed
Dhciolfi opened this issue Aug 8, 2019 · 2 comments · Fixed by #139
Closed

Unknown CMake command "add_compile_definitions". #137

Dhciolfi opened this issue Aug 8, 2019 · 2 comments · Fixed by #139

Comments

@Dhciolfi
Copy link

Dhciolfi commented Aug 8, 2019

Steps to reproduce

  1. Run sudo python3 setup.py install

Observed Results

Building with ptex support
CMake Error at CMakeLists.txt:52 (add_compile_definitions):
Unknown CMake command "add_compile_definitions".

Expected Results

  • It should setup properly

It seems that this area of code was modified in the last commit.
@mosra mosra mentioned this issue Aug 8, 2019
Merged
@mosra
Copy link
Collaborator

mosra commented Aug 8, 2019

Whoops, missed this one when reviewing #133. Fix for this is in #139.

@mosra mosra closed this as completed in #139 Aug 8, 2019
@mosra
Copy link
Collaborator

mosra commented Aug 8, 2019

Fix merged to master. To prevent issues like this happening in the future, the CI now explicitly checks for compatibility back to CMake 3.10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid using too new CMake features facebookresearch/habitat-sim
2 participants
@mosra @Dhciolfi