Implemented disabling logging configuration & added config file

[briankosw]

Motivation

Implemented disabling the configuration for Python logging, as described in #1021. Added notset.yaml configuration file for hydra/hydra_logging and hydra/job_logging.

Have you read the Contributing Guidelines on pull requests?

(Yes)/No

Test Plan

I tested my implementation locally by comparing the root logger's state before and after hydra.main. I wasn't sure how to write that and add it to the test suite.

Related Issues and PRs

N/A

[briankosw]

Do you have any suggestions for how tests should be implemented for such changes? What about documentation?

[jieru-hu]

Do you have any suggestions for how tests should be implemented for such changes? What about documentation?

for testing, i think these are good examples

hydra/tests/test_examples/test_configure_hydra.py

Lines 72 to 90 in 180ec59

	def test_logging(tmpdir: Path) -> None:
	cmd = [
	"examples/configure_hydra/logging/my_app.py",
	"hydra.run.dir=" + str(tmpdir),
	]
	result, _err = get_run_output(cmd)
	assert result == "[INFO] - Info level message"
	def test_workdir_config(monkeypatch: Any, tmpdir: Path) -> None:
	script = str(Path("examples/configure_hydra/workdir/my_app.py").absolute())
	monkeypatch.chdir(tmpdir)
	result, _err = get_run_output([script])
	assert Path(result) == Path(tmpdir) / "run_dir"
	result, _err = get_run_output(
	[script, "--multirun", "hydra/hydra_logging=disabled"]
	)
	assert Path(result) == Path(tmpdir) / "sweep_dir" / "0"

For documentation, the Hydra confs are already linked here https://hydra.cc/docs/next/configure_hydra/intro, so i think it's probably fine not to document it.

[jieru-hu]

Thx for working on this! Please fix the lint failures. Other than that, one small comment.
I will leave this to @omry for merging/accepting.

[shagunsodhani]

Some feedback

[omry]

Nice.

1. Add a news fragment.
2. Mention it in the docs (see bottom part of https://hydra.cc/docs/tutorials/basic/running_your_app/logging).

[jieru-hu]

Maybe something like the following? (to be more consistent with the other news entries, also no comma at the end.)

It is now possible to disable Hydra's logging configuration

[shagunsodhani]

redundant line?

[briankosw]

They're separate things: disabled disables the Python logging system such that any pre-existing loggers will also be disabled, while none disables the logging configuration that Hydra sets up. On another note, I did find that the documentation in general was a bit confusing since certain topics were described multiple times in multiple different places. Perhaps the documentation should be changed in general?

[shagunsodhani]

I was referring to this part:

Hydra to configure the logging.
and `hydra/hydra_logging` to `none`

[omry]

Great, thanks!