Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] failure while sanitiainzg exception stack trace in some cases #1739

Closed
omry opened this issue Jul 30, 2021 · 0 comments · Fixed by #1741
Closed

[Bug] failure while sanitiainzg exception stack trace in some cases #1739

omry opened this issue Jul 30, 2021 · 0 comments · Fixed by #1741
Assignees
Labels
bug Something isn't working
Milestone

Comments

@omry
Copy link
Collaborator

omry commented Jul 30, 2021

In some scenarios, one of the insepected frames in the stack trace does not have a module, resulting in a failure to print the underlying error.

The following looks like it's resolving it:

++ hydra/_internal/utils.py
@@ -248,6 +248,8 @@
                 while end is not None:
                     frame = end.tb_frame
                     mdl = inspect.getmodule(frame)
+                    if mdl is None:
+                        break
-                     assert mdl is not None
@omry omry added the bug Something isn't working label Jul 30, 2021
@omry omry added this to the Hydra 1.1.1 milestone Jul 30, 2021
@omry omry changed the title [Bug] [Bug] failure while sanitiainzg exception stack trace in some cases Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants