Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove handling of deprecated "old optional" defaults list syntax #1952

Merged
merged 1 commit into from Apr 16, 2022
Merged

remove handling of deprecated "old optional" defaults list syntax #1952

merged 1 commit into from Apr 16, 2022

Conversation

Jasha10
Copy link
Collaborator

@Jasha10 Jasha10 commented Jan 11, 2022 •
edited

In previous versions of hydra, the following two defaults lists were equivalent:

defaults:
  - optional foo: bar
defaults:
  - foo: bar
    optional: true

This PR removes support for the former latter syntax.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 11, 2022
@Jasha10
Copy link
Collaborator Author

Jasha10 commented Mar 10, 2022

I'm marking this PR as a draft until the new Hydra base_version functionality is in place.

@Jasha10 Jasha10 marked this pull request as draft March 10, 2022 04:15
@Jasha10 Jasha10 force-pushed the remove_old_optional_handling branch from 6ce2bbe to d770fd0 Compare April 16, 2022 13:53
pixelb
pixelb approved these changes Apr 16, 2022
View reviewed changes
Copy link
Contributor

@pixelb pixelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. thanks

@Jasha10 Jasha10 marked this pull request as ready for review April 16, 2022 23:37
@Jasha10 Jasha10 merged commit a78d1f6 into facebookresearch:main Apr 16, 2022
@Jasha10 Jasha10 deleted the remove_old_optional_handling branch April 16, 2022 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixelb pixelb pixelb approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Jasha10 @pixelb @facebook-github-bot