Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Relax pin to allow omegaconf 2.3 #2510

Closed
2 tasks done
weiji14 opened this issue Dec 20, 2022 · 2 comments
Closed
2 tasks done

[Bug] Relax pin to allow omegaconf 2.3 #2510

weiji14 opened this issue Dec 20, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@weiji14
Copy link

weiji14 commented Dec 20, 2022

馃悰 Bug

Description

Just reporting an issue when installing hydra with Python 3.11 on conda=forge. Currently, hydra=1.3.0 is pinned to omegaconf~=2.2 (>=2.2, <2.3) (see https://github.com/facebookresearch/hydra/blob/v1.3.0/requirements/requirements.txt#L1). Support for Python 3.11 in hydra was added in #2443, but Python 3.11 support was only added in omegaconf=2.3 (see https://github.com/omry/omegaconf/releases/tag/v2.3.0).

So for Python 3.11 to work properly, the version pinning needs to be relaxed to something like omegaconf>=2.2 instead.

Checklist

  • I checked on the latest version of Hydra
  • I created a minimal repro (See this for tips).

To reproduce

** Minimal Code/Config snippet to reproduce **

mamba create -n temp python=3.11 hydra-core=1.3.0

** Stack trace/error message **

Encountered problems while solving:
  - package hydra-core-1.3.0-pyhd8ed1ab_0 requires omegaconf 2.2.*, but none of the providers can be installed

Expected Behavior

The installation command should work

System information

  • Hydra Version : 1.3.0
  • Python version : 3.11
  • Virtual environment type and version : n/a
  • Operating system : Linux

Additional context

Add any other context about the problem here.

The unpinning will need to be done first on https://github.com/facebookresearch/hydra, and a patch version (1.3.1?) released, before the change can be propagated to https://github.com/conda-forge/hydra-core-feedstock.

@weiji14 weiji14 added the bug Something isn't working label Dec 20, 2022
@Jasha10
Copy link
Collaborator

Jasha10 commented Dec 21, 2022

Excellent, thanks for opening this issue @weiji14.

TODO:

  • Merge #2512
  • cherry pick #2512 to 1.3_branch (pr #2514)
  • release Hydra v1.3.1 with the relaxed pin

@Jasha10
Copy link
Collaborator

Jasha10 commented Dec 21, 2022

Done. Here's Hydra v1.3.1 on pypi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants