improve hydra.utils.get_{class,method,object} #2520
Merged
+177
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the error message for get_class failure-to-locate was imprecise.
facebook-github-bot
added
the
CLA Signed
Jasha10
changed the title
Jasha10
force-pushed
the
implement-get_object
branch
2 times, most recently
from
24d0949
to
47c9ac0
Compare
Jasha10
force-pushed
the
implement-get_object
branch
from
47c9ac0
to
ddc605e
Compare
|
Duh. didn't submit my pending comment. |
omry
reviewed
Jan 11, 2023
Comment on lines
+79
to
+80
| obj = _locate(path) | ||
| return obj |
There was a problem hiding this comment.
Is the only new thing here that this function does not check the object for being a callable?
omry
reviewed
Jan 12, 2023
| @@ -51,6 +67,22 @@ def get_method(path: str) -> Callable[..., Any]: | |||
| get_static_method = get_method | |||
|
|
|||
|
|
|||
| def get_object(path: str) -> Any: | |||
| """ | |||
| Look up a callable based on a dotpath. | |||
There was a problem hiding this comment.
the comment he is incorrect. object may not be a callable.
There was a problem hiding this comment.
Thanks. I've opened PR #2544 with a fixup.
|
Closes #1975 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
hydra.utils.get_objectfor an easier way to look up objects from a dotpath.Commits:
hydra.utils.get_objectmethod #2139)