Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] cant pass arg value that contains the char '=' #266

Closed
giladw opened this issue Oct 30, 2019 · 1 comment · Fixed by #272
Closed

[Bug] cant pass arg value that contains the char '=' #266

giladw opened this issue Oct 30, 2019 · 1 comment · Fixed by #272
Labels
bug Something isn't working
Milestone

Comments

@giladw
Copy link

giladw commented Oct 30, 2019

🐛 Bug

when passing argument value that contains the char '=' an error is thrown:
ValueError: too many values to unpack (expected 2)

To reproduce

python example.py input_path=s3://rawData/year=2019/month=10/day=29/data_raw_joined.parquet

** Stack trace/error message **

  File "/anaconda3/lib/python3.6/site-packages/hydra/_internal/config_loader.py", line 136, in _apply_defaults_overrides
    key, value = override.split("=")```
**Optional video**
If applicable, record a short [video](https://asciinema.org) with to help explain your problem.
You can also 

## Expected Behavior
I expect way to pass an argument that contains '=' in some other way

## System information
- 0.10.0
- macOS

@giladw giladw added the bug Something isn't working label Oct 30, 2019
@omry
Copy link
Collaborator

omry commented Oct 31, 2019

Hi Gilad,
Thanks for reporting.
This is a pretty simple bug to fix (I think). if you would like to try fixing it I can take a look at a PR.
(Please add tests as well if you do that).

I am traveling so it may take a few weeks before I can fix this).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants