Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Range support in BasicSweeper #393

Closed
jan-matthis opened this issue Jan 31, 2020 · 2 comments 路 Fixed by #825
Closed

[Feature Request] Range support in BasicSweeper #393

jan-matthis opened this issue Jan 31, 2020 · 2 comments 路 Fixed by #825
Labels
enhancement Enhanvement request
Milestone

Comments

@jan-matthis
Copy link
Contributor

jan-matthis commented Jan 31, 2020

馃殌 Feature Request

Motivation

It'd be great if Hydra's basic sweeper supported range sweeping out of the box.

Pitch

Provide a simple syntax for range sweeping, e.g.:

  • python foo.py a=1:5 -> python foo.py a=1,2,3,4,5
  • python foo.py a=1:10:2 -> python foo.py a=1,3,5,7,9

This has been implemented in @BadrYoubiIdrissi's range-sweeper plugin.

In addition, it might be helpful to disable range sweeping or change the separator char for people who rely on it.

Additional context

FR following discussion with @omry on Zulip.

@jan-matthis jan-matthis added the enhancement Enhanvement request label Jan 31, 2020
@omry omry added this to the 1.1.0 milestone Jan 31, 2020
@omry
Copy link
Collaborator

omry commented Jan 31, 2020

This syntax is consistent with the syntax in the coming Ax plugin.

I will look into supporting this in the basic sweeper in 1.1.0.

@omry omry modified the milestones: 1.1.0, 1.0.0 Jul 25, 2020
@omry omry closed this as completed in #825 Aug 12, 2020
@omry
Copy link
Collaborator

omry commented Aug 13, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhanvement request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants