Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix load_model missing argument #377

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

bot66
Copy link
Contributor

@bot66 bot66 commented Feb 23, 2024

What does this PR do?

Add the missing argument use_fast_kernels to the load_model function in chat completion inference example script

invoke:
https://github.com/facebookresearch/llama-recipes/blob/ce3c2ec4285d2b3626534b753b1a37e92049d31a/examples/chat_completion/chat_completion.py#L64

definition:
https://github.com/facebookresearch/llama-recipes/blob/ce3c2ec4285d2b3626534b753b1a37e92049d31a/src/llama_recipes/inference/model_utils.py#L8

Fixes # (issue)
Fix load_model missing argument

Feature/Issue validation/testing

Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A
    Logs for Test A

  • Test B
    Logs for Test B

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Thanks for contributing 馃帀!

@facebook-github-bot
Copy link

Hi @bot66!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@HamidShojanazeri HamidShojanazeri merged commit 5edd1a2 into meta-llama:main Feb 27, 2024
3 checks passed
@bot66 bot66 deleted the fix_load_model branch February 28, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants