Fsdp inference checkpoints #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chauhang
reviewed
Jul 25, 2023
inference/inference.py
Outdated
| parent_directory = os.path.dirname(current_directory) | ||
|
|
||
| # Append the parent directory to sys.path | ||
| sys.path.append(parent_directory) |
There was a problem hiding this comment.
Please move the code for path setting inside main / function
chauhang
reviewed
Jul 25, 2023
chauhang
reviewed
Jul 25, 2023
chauhang
reviewed
Jul 25, 2023
chauhang
suggested changes
Jul 25, 2023
There was a problem hiding this comment.
@HamidShojanazeri Thanks for getting this started. Please see comments inline
chauhang
reviewed
Jul 26, 2023
chauhang
reviewed
Jul 26, 2023
chauhang
suggested changes
Jul 26, 2023
There was a problem hiding this comment.
Please add steps used for testing this out, including below along with output of your test for verification:
- command to run and generate the pure fsdp checkpoint
- command for converting the checkpoint to HF format for inference
- command for running the inference
done. |
chauhang
reviewed
Jul 31, 2023
chauhang
reviewed
Jul 31, 2023
chauhang
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding converter script for converting FSDP sharded state dict to HF model for inference.