Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a consolidated resharding logic #376

Closed
ruanslv opened this issue Oct 3, 2022 · 2 comments · Fixed by #459
Closed

Create a consolidated resharding logic #376

ruanslv opened this issue Oct 3, 2022 · 2 comments · Fixed by #459
Assignees
Labels
better-eng Things that can help make things sane enhancement New feature or request

Comments

@ruanslv
Copy link
Contributor

ruanslv commented Oct 3, 2022

🚀 Feature Request

We run a single model shard in each GPU, with a combination of data and model parallel. We have a few different ways of doing resharding today (i.e. converting a model from X shards to Y shards), which should be consolidated to a single solution that we trust.

Supported model parallelism for input and output can be restricted to 1/2/4/8 (the number can change between input and output). Overall number of shards can be restricted to powers of 2 to start.

Motivation

We have three ways of resharding today:

Let's consolidate and clean-up the code. This will be useful for having a single code-path to load models later: #78

@tangbinh
Copy link
Contributor

@ruanslv @suchenzang It seems that the scripts have different assumptions about the checkpoint inputs and behave quite differently:

What would the checkpoint inputs for the consolidated script look like? Do we need to support all use cases mentioned above?

@suchenzang
Copy link
Contributor

Sounds like we need to deprecate the first two, lol. @stephenroller @ngoyal2707 any takes on the above? 😅

@suchenzang suchenzang added better-eng Things that can help make things sane and removed help wanted labels Oct 12, 2022
@tangbinh tangbinh linked a pull request Oct 26, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
better-eng Things that can help make things sane enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants