Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

There may be an error in line 268 in dialog_teacher.py #64

Closed
Chen-Wang-CUHK opened this issue May 12, 2017 · 4 comments
Closed

There may be an error in line 268 in dialog_teacher.py #64

Chen-Wang-CUHK opened this issue May 12, 2017 · 4 comments

Comments

@Chen-Wang-CUHK
Copy link

opt.get('no_images', False) should be self.opt.get('no_images', False) ?

@jiasenlu
Copy link
Contributor

jiasenlu commented May 12, 2017

Thanks, Yes, this was typo fixed in #54, waiting to merge to the master.

@Chen-Wang-CUHK
Copy link
Author

Chen-Wang-CUHK commented May 12, 2017 via email

@alexholdenmiller
Copy link
Member

Thanks Chen-Wang! Good catch

@alexholdenmiller
Copy link
Member

both of these should be fixed now

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants