This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
Change model input tokens to optional #1099
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D18253210 |
FanW123
pushed a commit
to FanW123/pytext
that referenced
this pull request
Nov 1, 2019
Summary: Pull Request resolved: facebookresearch#1099 The Byte LSTM does not need the input of tokens, which it inherits from LSTM language model. Making it optional and pass it as None will allow to model to skip build vocab part and report confusing OOV problems. Reviewed By: kmalik22 Differential Revision: D18253210 fbshipit-source-id: 246e7dfab9d200f55fd8c2e030a4036a1cc268a5
FanW123
force-pushed
the
export-D18253210
branch
from
231360e
to
94e0719
Compare
|
This pull request was exported from Phabricator. Differential Revision: D18253210 |
FanW123
force-pushed
the
export-D18253210
branch
from
94e0719
to
3b00089
Compare
FanW123
pushed a commit
to FanW123/pytext
that referenced
this pull request
Nov 5, 2019
Summary: Pull Request resolved: facebookresearch#1099 The Byte LSTM does not need the input of tokens, which it inherits from LSTM language model. Making it optional and pass it as None will allow to model to skip build vocab part and report confusing OOV problems. Reviewed By: kmalik22 Differential Revision: D18253210 fbshipit-source-id: be9060a9d94a850d1911346ca4e9c3679d05d18f
|
This pull request was exported from Phabricator. Differential Revision: D18253210 |
FanW123
pushed a commit
to FanW123/pytext
that referenced
this pull request
Nov 5, 2019
Summary: Pull Request resolved: facebookresearch#1099 The Byte LSTM does not need the input of tokens, which it inherits from LSTM language model. Making it optional and pass it as None will allow to model to skip build vocab part and report confusing OOV problems. Reviewed By: kmalik22 Differential Revision: D18253210 fbshipit-source-id: c217fc63c12de29ea5fba0aa972d51ffaf37fc8a
FanW123
force-pushed
the
export-D18253210
branch
from
3b00089
to
76861bf
Compare
|
This pull request was exported from Phabricator. Differential Revision: D18253210 |
FanW123
pushed a commit
to FanW123/pytext
that referenced
this pull request
Nov 5, 2019
Summary: Pull Request resolved: facebookresearch#1099 The Byte LSTM does not need the input of tokens, which it inherits from LSTM language model. Making it optional and pass it as None will allow to model to skip build vocab part and report confusing OOV problems. Reviewed By: kmalik22 Differential Revision: D18253210 fbshipit-source-id: 4de4a726c713b8f1d9b3f7991cef5118bf8d13c6
FanW123
force-pushed
the
export-D18253210
branch
from
76861bf
to
fd31ea1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D18253210 |
FanW123
pushed a commit
to FanW123/pytext
that referenced
this pull request
Nov 5, 2019
Summary: Pull Request resolved: facebookresearch#1099 The Byte LSTM does not need the input of tokens, which it inherits from LSTM language model. Making it optional and pass it as None will allow to model to skip build vocab part and report confusing OOV problems. Reviewed By: kmalik22 Differential Revision: D18253210 fbshipit-source-id: 05af4bfec1580e835f8576ab01a77a7ca222c5b1
FanW123
force-pushed
the
export-D18253210
branch
from
fd31ea1
to
2af4d7a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D18253210 |
Summary: Pull Request resolved: facebookresearch#1099 The Byte LSTM does not need the input of tokens, which it inherits from LSTM language model. Making it optional and pass it as None will allow to model to skip build vocab part and report confusing OOV problems. Reviewed By: kmalik22 Differential Revision: D18253210 fbshipit-source-id: 42080fae1c22bf86648892bb18d01a1ad07b6a9c
FanW123
force-pushed
the
export-D18253210
branch
from
2af4d7a
to
7f167a7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D18253210 |
|
This pull request has been merged in 1fdb7be. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The Byte LSTM does not need the input of tokens, which it inherits from LSTM language model. Making it optional and pass it as None will allow to model to skip build vocab part and report confusing OOV problems.
Reviewed By: kmalik22
Differential Revision: D18253210