Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor][PL][9/N] change the name of the _load_checkpoint to be more descriptive to contain test #1030

Closed
wants to merge 21 commits into from

Conversation

hackgoofer
Copy link
Contributor

@hackgoofer hackgoofer commented Jul 23, 2021

Stack from ghstack:

Differential Revision: D29888294

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jul 23, 2021
hackgoofer pushed a commit that referenced this pull request Jul 23, 2021
…tive to contain test

ghstack-source-id: bc7551543ad27405e8ac20cbd21849be6ac41428
Pull Request resolved: #1030
@hackgoofer hackgoofer changed the title [refactor] change the name of the _load_checkpoint to be more descriptive to contain test [refactor][PL][9/N] change the name of the _load_checkpoint to be more descriptive to contain test Jul 23, 2021
@hackgoofer
Copy link
Contributor Author

@ytsheng has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

…t to be more descriptive to contain test"

Differential Revision: [D29888294](https://our.internmc.facebook.com/intern/diff/D29888294)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

@ytsheng has updated the pull request. You must reimport the pull request before landing.

…t to be more descriptive to contain test"

Differential Revision: [D29888294](https://our.internmc.facebook.com/intern/diff/D29888294)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

@ytsheng has updated the pull request. You must reimport the pull request before landing.

@hackgoofer
Copy link
Contributor Author

@ytsheng has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

…t to be more descriptive to contain test"

Differential Revision: [D29888294](https://our.internmc.facebook.com/intern/diff/D29888294)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

@ytsheng has updated the pull request. You must reimport the pull request before landing.

@hackgoofer
Copy link
Contributor Author

@ytsheng has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

…t to be more descriptive to contain test"

Differential Revision: [D29888294](https://our.internmc.facebook.com/intern/diff/D29888294)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

@ytsheng has updated the pull request. You must reimport the pull request before landing.

@hackgoofer
Copy link
Contributor Author

@ytsheng has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

…t to be more descriptive to contain test"

Differential Revision: [D29888294](https://our.internmc.facebook.com/intern/diff/D29888294)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

@ytsheng has updated the pull request. You must reimport the pull request before landing.

…t to be more descriptive to contain test"

Differential Revision: [D29888294](https://our.internmc.facebook.com/intern/diff/D29888294)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

@ytsheng has updated the pull request. You must reimport the pull request before landing.

@hackgoofer
Copy link
Contributor Author

@ytsheng has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

…t to be more descriptive to contain test"

Differential Revision: [D29888294](https://our.internmc.facebook.com/intern/diff/D29888294)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

@ytsheng has updated the pull request. You must reimport the pull request before landing.

@hackgoofer
Copy link
Contributor Author

@ytsheng has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

…t to be more descriptive to contain test"

Differential Revision: [D29888294](https://our.internmc.facebook.com/intern/diff/D29888294)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

@ytsheng has updated the pull request. You must reimport the pull request before landing.

@hackgoofer
Copy link
Contributor Author

@ytsheng has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

…t to be more descriptive to contain test"

Differential Revision: [D29888294](https://our.internmc.facebook.com/intern/diff/D29888294)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

@ytsheng has updated the pull request. You must reimport the pull request before landing.

@hackgoofer
Copy link
Contributor Author

@ytsheng has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

…t to be more descriptive to contain test"

Differential Revision: [D29888294](https://our.internmc.facebook.com/intern/diff/D29888294)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

@ytsheng has updated the pull request. You must reimport the pull request before landing.

@hackgoofer
Copy link
Contributor Author

@ytsheng has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

…t to be more descriptive to contain test"

Differential Revision: [D29888294](https://our.internmc.facebook.com/intern/diff/D29888294)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

@ytsheng has updated the pull request. You must reimport the pull request before landing.

@hackgoofer
Copy link
Contributor Author

@ytsheng has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

…t to be more descriptive to contain test"

Differential Revision: [D29888294](https://our.internmc.facebook.com/intern/diff/D29888294)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

@ytsheng has updated the pull request. You must reimport the pull request before landing.

…t to be more descriptive to contain test"

Differential Revision: [D29888294](https://our.internmc.facebook.com/intern/diff/D29888294)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

@ytsheng has updated the pull request. You must reimport the pull request before landing.

…t to be more descriptive to contain test"

Differential Revision: [D29888294](https://our.internmc.facebook.com/intern/diff/D29888294)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

@ytsheng has updated the pull request. You must reimport the pull request before landing.

…t to be more descriptive to contain test"

Differential Revision: [D29888294](https://our.internmc.facebook.com/intern/diff/D29888294)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

@ytsheng has updated the pull request. You must reimport the pull request before landing.

@hackgoofer
Copy link
Contributor Author

@ytsheng has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot pushed a commit that referenced this pull request Sep 9, 2021
…e descriptive to contain test (#1030)

Summary: Pull Request resolved: #1030

Test Plan: Imported from OSS

Reviewed By: simran2905

Differential Revision: D29888294

Pulled By: ytsheng

fbshipit-source-id: 54919dc4e8448a1240b2cc72a364702aa7cf49c2
@apsdehal apsdehal deleted the gh/ytsheng/17/head branch October 5, 2021 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants