Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong docstring for mesh_edge_loss #60

Closed
m-nez opened this issue Feb 14, 2020 · 1 comment
Closed

Wrong docstring for mesh_edge_loss #60

m-nez opened this issue Feb 14, 2020 · 1 comment
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@m-nez
Copy link

m-nez commented Feb 14, 2020

/pytorch3d/loss/mesh_edge_loss.py

The docstring currently mentions that:

Each edge contributes equally to the final loss, regardless of
numbers of edges per mesh in the batch by weighting each mesh with the
inverse number of edges.

Which is wrong. Edges of meshes with relatively many edges have small weights.
It should be:
Each mesh contributes equally to the final loss, regardless of
numbers of edges per mesh in the batch by weighting each mesh with the
inverse number of edges.

@gkioxari
Copy link
Contributor

Yes you are correct! The language here is confusing. The code is the source of all truth! Thank you for bringing this to our attention! I will add a diff to fix this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants