Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit latest version of EvalTuner and clean up commits #23

Closed
wants to merge 5 commits into from

Conversation

cryptodeal
Copy link
Contributor

Must have been a bit tired last night because I messed up when merging commits to resolve conflicts; resubmitted with the updated code and cleaned up commit history.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 6, 2022
src/utils/eval_tuner.ts Outdated Show resolved Hide resolved
src/utils/eval_tuner.ts Outdated Show resolved Hide resolved
src/utils/eval_tuner.ts Outdated Show resolved Hide resolved
src/utils/index.ts Outdated Show resolved Hide resolved
@cryptodeal
Copy link
Contributor Author

cryptodeal commented Sep 10, 2022

Also, per convo with @bwasti on Discord, I've benchmarked manually calling eval once per iteration during benchmarks as a baseline:
Baseline_Eval_Manual_Bench

Here's the results w/o any calls to eval:
Screen Shot 2022-09-10 at 4 11 20 PM

Here's the performance running the same tests using EvalTuner with StochHillClimb EvalFn:
StochHillClimb_Eval_Fn_Bench

And here's the performance running the same tests using EvalTuner with Fast EvalFn:
Fast_EvalFn_Bench

I ran the tests a bunch to tweak/optimize the parameters for the benchmarks (generally solid default params), but for the actual screenshots I ran each of the above once, capturing the result from that initial run to avoid cherrypicking best runs.

@cryptodeal
Copy link
Contributor Author

Had mistakenly not removed an import for the enum that's been removed as it's no longer used per suggestion in code review; last push fixed it. Will stop working on this pending further feedback.

@bwasti
Copy link
Contributor

bwasti commented Sep 10, 2022

Benchmarking on GP100

Baseline:
Screen Shot 2022-09-10 at 5 06 26 PM

new EvalTuner(new Fast()):
Screen Shot 2022-09-10 at 5 07 35 PM

new EvalTuner(new StochHillClimb()):
Screen Shot 2022-09-10 at 5 09 03 PM

@bwasti
Copy link
Contributor

bwasti commented Sep 10, 2022

If you give it more time to warm up, the tuner gets noticeably better results:

Baseline:
Screen Shot 2022-09-10 at 5 17 44 PM

EvalTuner(Fast):
Screen Shot 2022-09-10 at 5 17 52 PM

@cryptodeal cryptodeal marked this pull request as draft October 15, 2022 15:26
@cryptodeal
Copy link
Contributor Author

Going to close so that I can start hacking at this again locally. Will reopen once I've got consistently improved performance out of the algo vs the more hit or miss performance of previous attempts.

@cryptodeal cryptodeal closed this Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants