Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

[Question] Did you use Discriminator for recent results #40

Closed
MaksymDel opened this issue Nov 15, 2018 · 1 comment
Closed

[Question] Did you use Discriminator for recent results #40

MaksymDel opened this issue Nov 15, 2018 · 1 comment

Comments

@MaksymDel
Copy link

Hi,

It is clear that you used discriminator for the models in the paper Unsupervised Machine Translation With Monolingual Data Only.

But do you also use it to obtain results for NMT models presented in Phrase-Based & Neural Unsupervised Machine Translation paper?

From the code it seems like if --n_dis parameter equals 0 (which is default), the discriminator is not used. You found it to have no positive effect?

Thanks!
Maksym

@glample
Copy link
Contributor

glample commented Nov 15, 2018

Hi,

Indeed, in the last paper we didn't find any benefits using the discriminator. That being said, we didn't tune it very well, but I don't think it would make a big difference even if well tuned.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants