Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

Bug with file path in get-data-xnli.sh #11

Closed
rajenchatterjee opened this issue Feb 21, 2019 · 3 comments
Closed

Bug with file path in get-data-xnli.sh #11

rajenchatterjee opened this issue Feb 21, 2019 · 3 comments

Comments

@rajenchatterjee
Copy link

Hi, There were couple of bugs in the "get-data-xnli.sh" script related to file path. The following is the fix:

  1. comment "mkdir -p $XNLI_PATH" (line 29) -- creating this directory prevents downloading XNLI-1.0.zip

  2. replace
    mkdir -p $PROCESSED_PATH/eval/XNLI
    rm $PROCESSED_PATH/eval/XNLI/*. -- getting error "cannot remove...no such file..."
    with
    if [ -d $PROCESSED_PATH/eval/XNLI ]; then
    rm -rf $PROCESSED_PATH/eval/XNLI
    fi
    mkdir -p $PROCESSED_PATH/eval/XNLI

@glample
Copy link
Contributor

glample commented Feb 21, 2019

Hi, thanks for finding this. I pushed d2289e3 this should fix 2).
I don't understand the issue in 1) though, why does it prevent the download?

@rajenchatterjee
Copy link
Author

for 1: I guess, because the XNLI-1.0.zip file will be downloaded if there is no directory with the name "$OUTPATH/XNLI-1.0", however, the command "mkdir -p $XNLI_PATH" (which is executed before downloading the zip file) already creates an empty directory
(NB: $XNLI_PATH is same as $OUTPATH/XNLI-1.0)

@glample
Copy link
Contributor

glample commented Feb 22, 2019

Ah, you are right, thanks. This commit fixes that, among other things: 2dc4b8f

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants