Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error Handling #33

Closed
mrfelpa opened this issue Aug 25, 2023 · 2 comments
Closed

Error Handling #33

mrfelpa opened this issue Aug 25, 2023 · 2 comments

Comments

@mrfelpa
Copy link

mrfelpa commented Aug 25, 2023

Hey guys, although captures AttributeError and ValueError exceptions in the get_many_faces function, doesn't provide any meaningful error handling. It's important to handle exceptions properly to provide clear feedback when something goes wrong. For exemple: except AttributeError as attr_error:
raise FaceAnalysisError(f"Attribute error in get_many_faces: {attr_error}")

@facefusion facefusion deleted a comment Aug 25, 2023
@henryruhs
Copy link
Contributor

Thanks for the free introduction to the world of error handling.

@henryruhs henryruhs closed this as not planned Won't fix, can't repro, duplicate, stale Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@henryruhs @mrfelpa and others