Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for https://packagecontrol.io/packages/Sass #68

Closed
PixelT opened this issue Nov 8, 2016 · 6 comments
Closed

Add support for https://packagecontrol.io/packages/Sass #68

PixelT opened this issue Nov 8, 2016 · 6 comments
Labels
T: feature Feature.

Comments

@PixelT
Copy link

PixelT commented Nov 8, 2016

Description

The inline previews at this moment is visible only if the color is in hex value.
Maybe should be visible also in rgb, rgba, hsl, hsla values?


Support Info

- ST ver.: 3125
- Platform: windows
- Arch: x64
- Plugin ver.: 2.2.0
- Install via PC: True
- mdpopups ver.: 1.11.0
- markdown ver.: 2.6.6
- pygments ver.: 2.1a0
- jinja2 ver.: 2.8

Steps to Reproduce Issue

Write in scss file:

$a: red;
$b: #fff;
$c: rgb(255, 255, 255);
$d: rgba(255, 255, 255, 1);
$e: hsl(0, 0%, 100%);
$f: hsla(0, 0%, 100%, 1);

a {
    text-decoration: none;
    background-color: red;
    background-color: #fff;
    background-color: rgb(255, 255, 255);
    background-color: rgba(255, 255, 255, 1);
    background-color: hsl(0, 0%, 100%);
    background-color: hsla(0, 0%, 100%, 1);
}

The preview for rgb(a) and hsl(a) doesn't work with variables in scss

@facelessuser
Copy link
Owner

ColorHelper has recently implemented an issue template. Support requires that the template be followed in order to get support.

But inline is supported for rgb, rgba, hsl, and hsla:

screenshot - 11_8_2016 1_41_55 pm

If you require further assistance, please update the opening post using the template, and in detail describe your issue and provide everything the template asks.

@facelessuser facelessuser added S: invalid Invalid report (user error, upstream issue, etc). Works as Expected labels Nov 8, 2016
@PixelT
Copy link
Author

PixelT commented Nov 8, 2016

Write in scss file:

$a: red;
$b: #fff;
$c: rgb(255, 255, 255);
$d: rgba(255, 255, 255, 1);
$e: hsl(0, 0%, 100%);
$f: hsla(0, 0%, 100%, 1);

a {
    text-decoration: none;
    background-color: red;
    background-color: #fff;
    background-color: rgb(255, 255, 255);
    background-color: rgba(255, 255, 255, 1);
    background-color: hsl(0, 0%, 100%);
    background-color: hsla(0, 0%, 100%, 1);
}

The preview for rgb(a) and hsl(a) doesn't work with variables in scss

@facelessuser
Copy link
Owner

I've updated the opening post. That is what I am looking for in the future.

You also need to tell me what syntax highlighter you are using in this example (provide the link to it please).

@facelessuser facelessuser removed S: invalid Invalid report (user error, upstream issue, etc). Works as Expected labels Nov 8, 2016
@PixelT
Copy link
Author

PixelT commented Nov 9, 2016

For scss I'm using this package:
https://packagecontrol.io/packages/Sass

@facelessuser
Copy link
Owner

Most likely the scopes aren't including them. I will take a look.

@facelessuser facelessuser changed the title Inline previews other than hex Add support for https://packagecontrol.io/packages/Sass Nov 10, 2016
@facelessuser facelessuser added the T: feature Feature. label Nov 10, 2016
@facelessuser
Copy link
Owner

Fix will be in the next release. I tested only very basic things as I don't use Sass. So when it releases, you will have to test it to see if it behaves well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: feature Feature.
Projects
None yet
Development

No branches or pull requests

2 participants