Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for CSS variables #69

Closed
oalberdi opened this issue Nov 21, 2016 · 8 comments
Closed

Support for CSS variables #69

oalberdi opened this issue Nov 21, 2016 · 8 comments
Labels
P: maybe Pending approval of low priority request. S: duplicate The issue has been previously reported. T: feature Feature.

Comments

@oalberdi
Copy link

oalberdi commented Nov 21, 2016

Hi,
would be great also to have support for the new css variables, often used for color.
They are set using custom property notation (e.g. --main-color: black;) and are accessed using the var() function (e.g. color: var(--main-color);)

Both, displaying the color next to the var, or function on right menu "go to definition" would be awesome.

Thanks!

Support Info

  • ST ver.: 3125
  • Platform: windows
  • Arch: x64
  • Plugin ver.: 2.2.0
  • Install via PC: True
  • mdpopups ver.: 1.12.1
  • markdown ver.: 2.6.6
  • pygments ver.: 2.1a0
  • jinja2 ver.: 2.8
@facelessuser
Copy link
Owner

facelessuser commented Nov 23, 2016

@oalberdi Thanks for your interest in this plugin. Recently I added a template for new issues (I am still iterating through to make more clear in it what I am looking for in the issues) and I currently require people to use the template in order to get an official response. Your description is fine, but you can you also add the support info that the template asks for? https://github.com/facelessuser/ColorHelper/blob/master/.github/ISSUE_TEMPLATE.md#support-info.

I'm trying to get everyone in the habit of following the template so I don't have to ask people for common stuff. And I can be sure that they aren't missing a feature because they are on old versions etc. While this is clearly not the case with your request, I have to be consistent with everyone.

Thanks.

@facelessuser facelessuser added the S: invalid Invalid report (user error, upstream issue, etc). label Nov 27, 2016
@oalberdi
Copy link
Author

Hi,
Ok. I understand. Sorry for not following the template.
Thanks for the reply.

@facelessuser
Copy link
Owner

I went ahead and updated the opening post with the most recent version I am using. Each issue is an example to others, so I do this for consistency. Even when I create an issue, I put in my current versions to encourage the same from others.

As for your request. Currently there are no plans for this. I have a big refactoring to take place soon to make the plugin more flexible. People want to use this outside of just CSS/html. This is going to take me a bit to do. As for Sass/CSS/SCSS variables, I am undecided on this at the present. This would be very stylesheet specific, but I am not against it. But I'll have to see if/how it would fit into the current code. I'm actually not a web developer, so when I created this, things such as this were not considered.

I will have to think about this.

@facelessuser facelessuser added P: maybe Pending approval of low priority request. and removed S: invalid Invalid report (user error, upstream issue, etc). labels Nov 29, 2016
@jrappen
Copy link

jrappen commented Oct 23, 2017

@facelessuser Don't want to go too far off-topic...Just a quick FYI.

When requiring people to fill out the issue template, you could also prefill the issue body directly from Sublime by opening a new browser tab. Format below:

https://github.com/facelessuser/ColorHelper/issues/new/?
    labels=discussion,watchlist&
    assignee=facelessuser&
    title=Some%20title&
    body=Some%20body
  • Haven't tested applying Projects or Milestones, but I assume that's similar.
  • Applying those two, assignees and labels will naturally only work for repo maintainers who click the link.
  • Title and body though works for anybody.

@facelessuser
Copy link
Owner

This is interesting. I guess you could open up a Issue view where you specify title and body (some of it prefilled). And then run a command to create the issue. That could work. I'd have to play with it and ensure I could format it correctly, but thanks for the tip.

@facelessuser facelessuser added the T: feature Feature. label Oct 26, 2017
@kaiserkiwi
Copy link

Recently started to use CSS variables in a new project. It’s a real pity that ColorHelper doesn’t supports this feature. I would be very grateful if you could consider this in a future release as CSS variables become more common.

@facelessuser
Copy link
Owner

@kaiserkiwi, I support a bunch of different plugins for Sublime Text, and even some repos outside of that. This is extremely low priority for me currently (assuming I decide to follow through with this).

@facelessuser
Copy link
Owner

@gir-bot add S: duplicate

Closing as a duplicate of #142

@gir-bot gir-bot added the S: duplicate The issue has been previously reported. label Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P: maybe Pending approval of low priority request. S: duplicate The issue has been previously reported. T: feature Feature.
Projects
None yet
Development

No branches or pull requests

5 participants