Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LGTM command #41

Closed
gir-bot opened this issue Oct 28, 2019 · 1 comment
Closed

LGTM command #41

gir-bot opened this issue Oct 28, 2019 · 1 comment
Labels
skip-triage Tells bot to not tag a new issue with 'triage'. T: feature Feature.

Comments

@gir-bot
Copy link
Collaborator

gir-bot commented Oct 28, 2019

Add a way so we can say @bot lgtm in an issue, and it will clear any wip, triage, and/or review labels (depending on the issue type).

Optionally, you can say @bot lgtm, [key], where [key] is some user defined key, and appropriate labels will be set.

So, for an issue, I may say

@gir-bot lgtm, confirmed

And it may clear the triage label set the bug label and the confirmed label (as defined by the user).

Or if in a pull request, maybe:

@gir-bot lgtm, approved

And it would clear all the wip and review labels and set the label approved.

If we say:

@gir-bot lgtm

It would simply just remove the appropriate labels.

@gir-bot gir-bot added T: feature Feature. skip-triage Tells bot to not tag a new issue with 'triage'. labels Oct 28, 2019
@gir-bot
Copy link
Collaborator Author

gir-bot commented Oct 29, 2019

Probably not going to implement the additional parameter for adding labels. If we do this, it will be most likely be separate commands called add and remove. There you could define aliases to bulk assign related labels. LGTM will be used to simply remove "blocker" labels and assign optionally assign labels to indicate acceptance.

@gir-bot gir-bot closed this as completed Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-triage Tells bot to not tag a new issue with 'triage'. T: feature Feature.
Projects
None yet
Development

No branches or pull requests

1 participant