Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we have APIException inherit from ZenpyException? #521

Open
jhorowitz opened this issue Sep 24, 2022 · 1 comment
Open

Can we have APIException inherit from ZenpyException? #521

jhorowitz opened this issue Sep 24, 2022 · 1 comment

Comments

@jhorowitz
Copy link

It'd be nice if there was one singular exception which we could catch to handle all forms of exceptions from Zenpy. Every exception in lib.exception inherits from ZenpyException except for APIException which inherits directly from Exception. I think anyone catching ZenpyException would probably want it to catch APIException as well.

If you agree, I'd be happy to make a PR to implement it. I've been using the library a lot so I'd like to contribute back and help improve it. This seems like a good first PR!

@cryptomail
Copy link
Collaborator

Sometimes I read the backlog.
Then sometimes I get sad because this has lied fallow.
I think this is a great idea. If you want to get involved and do that I'd:

  1. Make the change
  2. See if the tests pass
  3. Submit the PR
Screenshot 2023-09-19 at 6 55 23 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants