Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ExtractCssChunksPlugin.loader is a string #291

Merged
merged 1 commit into from Aug 9, 2020
Merged

fix: ExtractCssChunksPlugin.loader is a string #291

merged 1 commit into from Aug 9, 2020

Conversation

christophehurpeau
Copy link
Contributor

Because else it doesn't work with:

{
          loader: CssExtractPlugin.loader,
          options: { hmr: !production && target !== 'node' },
        }

type Loader is string | NewLoader and NewLoader is:

interface NewLoader {
        loader: string;
        options?: { [name: string]: any };
    }

@christophehurpeau
fix: ExtractCssChunksPlugin.loader is a string
98e37e2 
Because else it doesn't work with:
```
{
          loader: CssExtractPlugin.loader,
          options: { hmr: !production && target !== 'node' },
        }
```

type Loader is `string | NewLoader` and `NewLoader` is:

```
interface NewLoader {
        loader: string;
        options?: { [name: string]: any };
    }
```
@ScriptedAlchemy ScriptedAlchemy merged commit c640252 into faceyspacey:master Aug 9, 2020
@ScriptedAlchemy
Copy link
Collaborator

🎉 This PR is included in version 4.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScriptedAlchemy ScriptedAlchemy Awaiting requested review from ScriptedAlchemy ScriptedAlchemy is a code owner

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@christophehurpeau @ScriptedAlchemy