Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: preload css #300

Merged
merged 3 commits into from Oct 15, 2020
Merged

feat: preload css #300

merged 3 commits into from Oct 15, 2020

Conversation

mrtnvh
Copy link
Contributor

@mrtnvh mrtnvh commented Oct 14, 2020

Description:

  • Checks if browser supports <link rel="preload">. If not, fallback to original functionality
  • Adds extracted stylesheet preload
  • Listens to onload event of preload, adds stylesheet when fired.

Forked implementation of webpack-contrib/mini-css-extract-plugin#344
Originated in nuxt/nuxt#8060
Fixes #260

  • No breaking changes
  • Updated tests, all pass ✅
  • Does this also need updates to the documentation?

@ScriptedAlchemy ScriptedAlchemy merged commit fdc5e7b into faceyspacey:master Oct 15, 2020
@mrtnvh mrtnvh deleted the feature/preload branch October 15, 2020 06:57
@mrtnvh
Copy link
Contributor Author

mrtnvh commented Oct 15, 2020

Thanks for the merge, @ScriptedAlchemy! Looking forward to the updated NPM package.

@mrtnvh
Copy link
Contributor Author

mrtnvh commented Oct 30, 2020

Hi @ScriptedAlchemy,

Hope you're doing well. Do you perhaps see the opportunity of deploying this feature to npm?

@ScriptedAlchemy
Copy link
Collaborator

Will publish tomorrow

@ScriptedAlchemy
Copy link
Collaborator

🎉 This PR is included in version 4.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@SuperOleg39
Copy link

Hello!

Add a few lates comments to PR changes (duplicate my comment from original PR)

What do you think @vanhoofmaarten, @ScriptedAlchemy ?

@kurtinge kurtinge mentioned this pull request Jan 8, 2021
Merged
@kurtinge
Copy link
Contributor

kurtinge commented Jan 8, 2021

We have the same issue as @SuperOleg39 - I've made a PR that prevents this from happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScriptedAlchemy ScriptedAlchemy Awaiting requested review from ScriptedAlchemy ScriptedAlchemy is a code owner

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Preload css request instead of prefetch
4 participants
@mrtnvh @ScriptedAlchemy @SuperOleg39 @kurtinge