Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs request for combination with vendor chunks and or AutoDLL Plugin #18

Closed
swernerx opened this issue Jul 18, 2017 · 3 comments
Closed

Comments

@swernerx
Copy link
Contributor

I am currently trying to add the AutoDll Plugin to my build chain as it was reported before to work with this solution. Unfortunately I had no direct success. The vendor entry point does not seem to be visible for this plugin. It just lists the default set of bootstrap + dynamic + main. But no vendor. Is there any magic trick or option to utilize?

@swernerx
Copy link
Contributor Author

I was wondering whether this is related to: asfktz/autodll-webpack-plugin#23

@faceyspacey
Copy link
Owner

faceyspacey commented Jul 18, 2017

It is, and I researched it to attempt to do a PR to the autodll package--basically Webpack has it planned for the future to allow plugin authors to add to stats. Currently we cannot--unless I'm missing something.

So the chunk created by autodll won't be in stats.assetsByChunkName, and there's nothing we can do about it. You just gotta append it to the page manually like we always have done.

Feel free to add it to the readme as a PR.

The challenge with the setup I've proposed through these tools is that no matter which way you slice it, it requires lots of setup/configuration. That's the price we pay for frameworkless flexibility vs. something like Next.js.

Basically, the notes on webpack "externals" is the beginning of a troubleshooting.md. I'm not sure if the entire webpack configuration docs should go there, but probably things like the hashed/named module ids stuff should go there as well. We're gonna need a complete list of "gotchas" and configuration requirements in one place.

Webpack Flush Chunks fyi will be renamed universal-render. I already own the npm package. There's a lot more coming out. Any help is much appreciated to bring this all together.

Also note, as everything comes together under the universal-render umbrella it will simplify many things. So we will achieve soon enough the best we can in frameworkless npm/react/webpack land.

@faceyspacey
Copy link
Owner

There's a note added to the readme:

https://github.com/faceyspacey/webpack-flush-chunks#autodllplugin

If there's more you feel should be said, go for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants