Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue98 JUNIT5, Spring Boot2, better example projects (boot1.5 & boot2.1) #213

Closed
uweschaefer opened this issue Jun 21, 2019 · 2 comments
Closed

Comments

@uweschaefer
Copy link
Member

From @uweschaefer on 2018-11-17 22:02:01 +0000 UTC

Copied from original issue: Mercateo/factcast#213

@uweschaefer
Copy link
Member Author

From @codecov[bot] on 2018-11-17 22:02:13 +0000 UTC

Codecov Report

Merging #213 into master will increase coverage by 0.11%.
The diff coverage is 83.72%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #213      +/-   ##
============================================
+ Coverage      76.2%   76.31%   +0.11%     
+ Complexity      420      417       -3     
============================================
  Files            52       52              
  Lines          1408     1385      -23     
  Branches        126      126              
============================================
- Hits           1073     1057      -16     
+ Misses          243      239       -4     
+ Partials         92       89       -3
Impacted Files Coverage Δ Complexity Δ
...a/org/factcast/client/cache/CachingFactLookup.java 100% <ø> (ø) 1 <0> (ø) ⬇️
...java/org/factcast/store/pgsql/CatchupStrategy.java 100% <ø> (ø) 2 <0> (ø) ⬇️
...ast-core/src/main/java/org/factcast/core/Fact.java 79.31% <ø> (ø) 11 <0> (ø) ⬇️
...ore/pgsql/internal/catchup/PGCatchUpFetchPage.java 90.9% <ø> (ø) 5 <0> (ø) ⬇️
...re/src/main/java/org/factcast/core/IdOnlyFact.java 100% <ø> (ø) 6 <0> (ø) ⬇️
...e/pgsql/internal/catchup/queue/PGQueueCatchup.java 7.27% <ø> (ø) 5 <0> (ø) ⬇️
...e/src/main/java/org/factcast/core/DefaultFact.java 100% <ø> (ø) 18 <0> (ø) ⬇️
...src/main/java/org/factcast/core/spec/FactSpec.java 100% <ø> (ø) 7 <0> (ø) ⬇️
...cast/client/grpc/IncompatibleProtocolVersions.java 100% <ø> (ø) 1 <0> (ø) ⬇️
...main/java/org/factcast/core/util/FactCastJson.java 95.23% <ø> (ø) 10 <0> (ø) ⬇️
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bc3710...d055d41. Read the comment docs.

@uweschaefer
Copy link
Member Author

From @codacy-bot on 2018-11-17 22:05:53 +0000 UTC

Codacy Here is an overview of what got changed by this pull request:

Complexity decreasing per file
==============================
+ factcast-store-pgsql/src/main/java/org/factcast/store/pgsql/internal/listen/PGListener.java  -2
         

See the complete overview on Codacy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant