Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky SubscriptionReconnectionITest #2484

Closed
uweschaefer opened this issue Oct 10, 2023 · 0 comments · Fixed by #2485 or #2487
Closed

Fix flaky SubscriptionReconnectionITest #2484

uweschaefer opened this issue Oct 10, 2023 · 0 comments · Fixed by #2485 or #2487

Comments

@uweschaefer
Copy link
Member

Describe the bug
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.807 s -- in org.factcast.itests.factus.lock.StateTokenTest_Latest
[INFO]
[INFO] Results:
[INFO]
Error: Failures:
Error: SubscriptionReconnectionITest.subscribeWithFailingReconnect:155
Expecting code to raise a throwable.
[INFO]
Error: Tests run: 100, Failures: 1, Errors: 0, Skipped: 0

FactCast Server/Client Version
0.7.0-RC

To Reproduce
https://github.com/factcast/factcast/actions/runs/6417741029/job/17424111193?pr=2334
@leflamm leflamm linked a pull request Oct 10, 2023 that will close this issue
2484: fix flaky test, batchsize=1, relax time constraints #2485
Merged
@leflamm leflamm reopened this Oct 10, 2023
@leflamm leflamm linked a pull request Oct 10, 2023 that will close this issue
2484: remove unnecessary duration assertion #2487
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@uweschaefer @leflamm