Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dropdowns in input groups #52

Closed
pbugnion opened this issue Nov 11, 2018 · 2 comments
Closed

Allow dropdowns in input groups #52

pbugnion opened this issue Nov 11, 2018 · 2 comments

Comments

@pbugnion
Copy link
Member

pbugnion commented Nov 11, 2018

Reactstrap supports dropdowns in input groups (see docs, for instance) via the InputGroupButtonDropdown component.

This just passes an addonType prop to a Dropdown component. See:

  • the InputGroupButtonDropdown source
  • how the underlying Dropdown component handles the addonType prop.

I think the easiest would be to add an addonType prop to Dropdown. I don't think we need to replicate InputGroupButtonDropdown, since it just wraps Dropdown and we would need to copy all the prop types.

Happy to implement this if we think it's the right thing to do. If we do this, we should amend the documentation on input groups (PR #51 ) to document dropdowns.

@tcbegley
Copy link
Collaborator

Nice, I think this would be a good addition. I also favour exposing extra options in the api of our DropdownMenu component over adding a new component. Very happy for you to have a go at implementing this.

@pbugnion
Copy link
Member Author

Closed by PR #59.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants