Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dash dev tools and Dash bootstrap dark themes #583

Closed
vikigenius opened this issue May 16, 2021 · 4 comments
Closed

Dash dev tools and Dash bootstrap dark themes #583

vikigenius opened this issue May 16, 2021 · 4 comments

Comments

@vikigenius
Copy link

Please fill out the below information as much as possible.

  • dash version: #1.20.0
  • dash-bootstrap-components version: #0.12.2
  • components affected by bug: Dev Tools

What is happening?

When using a Dark theme such as DARKLY or by following #147 and using the custom style sheets provided in https://github.com/tcbegley/dash-bootstrap-css the DEV tools for example when showing errors has very poor contrast.

scrot_20210516_142357

What should be happening?

DEV tools should have better contrast.

How do I fix this ?

@tcbegley
Copy link
Collaborator

Hey, thanks for raising this. I think this will be a problem more broadly with any dark theme that globally sets the font color to white or something light. I think the best thing would be to raise an issue / submit a fix to Dash itself. It looks like they set the background color of the debug menu but aren't seeing the text color. I'm happy to do that but it will probably be a couple of days before I have a chance to do so.

@vikigenius
Copy link
Author

Done: plotly/dash#1649

@AnnMarieW
Copy link
Contributor

FYI - This will be fixed in the next release of Dash
plotly/dash#1664 was just merged. 🎊

@tcbegley
Copy link
Collaborator

tcbegley commented Jul 3, 2021

Closing this as it will be resolved by the next version of Dash.

@tcbegley tcbegley closed this as completed Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants