Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer screen aspect ratio #8

Open
simc opened this issue Sep 19, 2018 · 6 comments
Open

Prefer screen aspect ratio #8

simc opened this issue Sep 19, 2018 · 6 comments

Comments

@simc
Copy link

simc commented Sep 19, 2018

Hi,

This plugin is awesome 馃憤

Would it be possible to prefer here an aspect ratio that matches the screen aspect ratio to allow full screen barcode scanners?

Thank you!

@facundomedica
Copy link
Owner

Hi! Thanks for opening this issue! Does this help you? https://github.com/dragosholban/flutter_qr_test/blob/master/lib/CodeReaderScreen.dart#L50

Cheers!

@facundomedica
Copy link
Owner

Ok, thanks for trying that! I think it could be a bit tricky to get this right because we also have to check on iOS. I imagine that there should be a way to achieve this using only Flutter but I don't have the time right now to do the required tests. Maybe on the weekend I can take a deeper look at this!

@simc
Copy link
Author

simc commented Sep 19, 2018

When we solve this in flutter, part of the image (in my case the right and left edge) will not be visible any more...

I think the problem is that the aspect ratio of the chosen camera resolution does not match the screen aspect ratio. Maybe there should be a desiredAspectRatio option in QRReaderController or just a option for custom camera resolution.

@Vanethos
Copy link

Any news on this?

@facundomedica
Copy link
Owner

No news on this, I haven't had the time to investigate but I'm open for PRs

@Vanethos
Copy link

I'm trying now to solve this, but honestly after looking at the source code and firebase's ml vision and flutter camera, don't know where to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants