Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check in Cargo.lock #26

Closed
legendofmiracles opened this issue May 26, 2021 · 1 comment
Closed

Check in Cargo.lock #26

legendofmiracles opened this issue May 26, 2021 · 1 comment

Comments

@legendofmiracles
Copy link
Contributor

This helps with reproducibility, and is also the recommended way for rust programs.
The .gitignore says it ignores it, because this program is a library, which just isn't true.

It would also stop distro maintainers from having to patch in the Cargo.lock, as seen here: https://github.com/NixOS/nixpkgs/pull/124539/files

Thanks!

@facundoolano
Copy link
Owner

@legendofmiracles Thanks for reporting.

When it's available, I would appreciate if you send a PR with instructions to install with nix in the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants