Lags because of lighting

[fredreichbier]

Hi there!

I'm able to use the client to connect to mineserver, which is awesome!, but unfortunately it's really stuttering, which means that the FPS are at ~10 and it just generally feels really laggy -- most of the time! But after some time on the server, there also are periods that feel very smooth.

The profiler shows that when it's laggy, up to 90% of time is spent in the tick section (which isn't the case for the official server). More specifically, in tick.level.checkLight.unspecified. So as @fador suggested in the IRC, it seems to be related to lighting.

Since I have no clue how lighting works -- does anybody have an idea why this happens and how to fix it? I would love to try to fix it, but I just have no idea where to start :)

[SpyderLink]

SpyderLink@8cb417a
You can start from here :)

[Justasic]

This seems to have fixed it although @fador hasn't merged it.

[fador]

Yeah sorry, I forgot to check this =)
@ IRC:
13:38 @fador I'm just wondering that setting the byte from 0 to 1 should require additional 16x16 byte array where you define the biome stuff...
13:39 @fador so why does it work =D
13:39 @fador or am I missing something
13:39 @fador or maybe it interprets something else as the biome array..
13:43 @fador ok so the byte is
13:43 @fador Ground-up continuous boolean This is True if the packet represents all sections in this vertical column, where the primary bit map specifies exactly which sections are included, and which are air.
13:43 @fador and there should be biome array inside the gzipped data
13:43 @fador Biome array (1 byte per XZ chunk, 256 bytes total, only sent if 'ground up continuous' is true)
13:44 @fador so actually when you dont push it there the client might just add zeros there =)

Thanks @SpyderLink ..I'll merge it when I get home ;)

[fador]

I'll close this for now since it seems to be fixed