-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More A/W/DeclareWide Alias pattern anomalies #29
Comments
Nice timing, right after I finally post a major update 🤣 Since URLDownloadToFile is a popular function I've gone ahead and posted a quick update again just fixing this issue. I looked for other instances of A" ( to find other aliases like that but the other 5 were correct. If you find any I've missed, please open a new issue, and of course keep the bug reports of all kinds coming 🙂 This issue fixed in 8.0.403, now available. Thanks! |
I just ran the search for Aliased A's and the only ones that I found look intentional, like: Public Declare PtrSafe Function PostAppMessageA Lib "user32" Alias "PostThreadMessageA" (ByVal idThread As Long, ByVal Msg As Long, ByVal wParam As LongPtr, lParam As Any) As BOOL
Public Declare PtrSafe Function GetWindowLongA Lib "user32" Alias "GetWindowLongPtrA" (ByVal hWnd As LongPtr, ByVal nIndex As GWL_INDEX) As LongPtr
Public Declare PtrSafe Function SetWindowLongA Lib "user32" Alias "SetWindowLongPtrA" (ByVal hWnd As LongPtr, ByVal nIndex As GWL_INDEX, ByVal dwNewLong As LongPtr) As LongPtr
Public Declare PtrSafe Function GetClassLongA Lib "user32" Alias "GetClassLongPtrA" (ByVal hWnd As LongPtr, ByVal nIndex As GCL_Index) As LongPtr
Public Declare PtrSafe Function SetClassLongA Lib "user32" Alias "SetClassLongPtrA" (ByVal hWnd As LongPtr, ByVal nIndex As GCL_Index, ByVal dwNewLong As LongPtr) As LongPtr So I think your latest version looks good! |
Yup those are all intentional and correct, thanks for double checking 👍 |
These don't follow the A/W/DeclareWide Alias pattern. Looks like the A's are aliased (as opposed to W's) and hence one of our filtering passes incorrectly replaced "DeclareWide" with "Declare" from the (unaliased) W's. Looks like the "standard" W entries were not originally included(?). When I get time I'll run a search for Aliased A's to check if there are any others like this.
The text was updated successfully, but these errors were encountered: