Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload map/mod without login/session check #60

Closed
IDragonfire opened this issue Mar 30, 2015 · 1 comment
Closed

Upload map/mod without login/session check #60

IDragonfire opened this issue Mar 30, 2015 · 1 comment

Comments

@IDragonfire
Copy link
Contributor

Upload map/mods don't check login/session variable

https://github.com/FAForever/server/blob/develop/src/lobbyconnection.py#L369
https://github.com/FAForever/server/blob/develop/src/lobbyconnection.py#L487

Is that okay?
@Sheeo
Copy link
Member

Sheeo commented Apr 4, 2015

We should generally be working on the assumption that any communication after the initial handshake is authenticated communication, so we should not need to check this here.

@Sheeo Sheeo closed this as completed Apr 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Sheeo @IDragonfire