You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Please consider renaming didSubscribe to didMount so that it is crystal clear what this is doing.
I'm not sure it is clear immediately to users how this aligns to React or Vue. The fact that didSubscribe isn't handled server side means that 'For handling side-effects upon first subscription.' isn't true in every circumstance.
The added advantage is that new developers who have not seen proppy, but have used recompose should immediately understand what 'didMount' does.
The text was updated successfully, but these errors were encountered:
Brilliant package. I really like this.
Please consider renaming didSubscribe to didMount so that it is crystal clear what this is doing.
I'm not sure it is clear immediately to users how this aligns to React or Vue. The fact that didSubscribe isn't handled server side means that 'For handling side-effects upon first subscription.' isn't true in every circumstance.
The added advantage is that new developers who have not seen proppy, but have used recompose should immediately understand what 'didMount' does.
The text was updated successfully, but these errors were encountered: