Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Leaderboard project #1

Merged
merged 14 commits into from Apr 7, 2022
Merged

Build Leaderboard project #1

merged 14 commits into from Apr 7, 2022

Conversation

fahdrahali
Copy link
Owner

@fahdrahali fahdrahali commented Apr 6, 2022

Create a project "Leaderboard" using:

  • Use Gitflow.
  • Use webpack to bundle JavaScript.
  • create a webpack config file.
  • Create a folder src.
  • Create an HTML and CSS and Javascript file.
  • add a plain HTML markup.

Copy link

@AmaduKamara AmaduKamara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi <STUDENT_MENTION>,

While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

Invalid Code Review Request

You have submitted a project, that has linter failures.

  • Kindly fix your linter errors and then resubmit for a review 👍

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


Invalid Code Review Request does not count into the code reviews limit.

Copy link

@BenMukebo BenMukebo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fahdrahali

You did a great job so far 👏🏼 👏🏼
There are some issues that you still need to work on to go to the next project but you are almost there!

To highlight 💪🏻

  • No linter errors. ✔️
  • Gitflow was correctly used. ✔️
    👍 Good job!

STATUS: CHANGES REQUESTED ♻️

Please Check the comments under the review and make all required changes

  • Please, Write a meaningful title for your pull request and always add a short summary of changes introduced in the pull request. you can check the Professional repo - basic rules

  • Kindly, Add a descriptive README file to your project, A professional README file should have a project title, project description, list of technology used in the project, instructions to set the project up locally and it will be great to add instructions on how to run the project. This includes npm install , npm start etc, please refer to this template, you can copy and paste the content but remember to customize it to your project.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏 💻
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please ping me @BenMukebo when you comment so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Copy link

@CollinsTatang CollinsTatang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fahdrahali,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉
image

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag @CollinsTatang in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@fahdrahali fahdrahali merged commit af4dbf5 into develop Apr 7, 2022
@fahdrahali fahdrahali changed the title Leaderboard: setup project Build Leaderboard project Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants