Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assets UTF-8 #4

Closed
Laguna001 opened this issue Oct 6, 2023 · 2 comments · Fixed by #5
Closed

Assets UTF-8 #4

Laguna001 opened this issue Oct 6, 2023 · 2 comments · Fixed by #5
Labels
bug Something isn't working

Comments

@Laguna001
Copy link

It does not recognize special Spanish characters á, é, í, ó, ú, ñ, etc.

<script src="/{{ minify('/js/layouts/example.js') }}" charset="UTF-8"></script>
@fahlisaputra
Copy link
Owner

@Laguna001 Thanks for reporting bugs!

It seems that the problem is with the Javascript Obfuscator, which uses PHP's ord() function which is only able to convert the first byte of a string to a value between 0 and 255.
See: https://www.php.net/manual/en/function.ord.php

image

I'll try to fix it asap. Thanks!

@fahlisaputra fahlisaputra added the bug Something isn't working label Oct 6, 2023
@fahlisaputra fahlisaputra linked a pull request Oct 6, 2023 that will close this issue
@fahlisaputra fahlisaputra reopened this Oct 6, 2023
@fahlisaputra
Copy link
Owner

@Laguna001 looks like it's working now.

image

Please update package to v.1.1.1
https://github.com/fahlisaputra/laravel-minify/releases/tag/v1.1.1

composer update fahlisaputra/laravel-minify

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants