Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add window icon support #10

Closed
faiface opened this issue Apr 30, 2017 · 2 comments
Closed

Add window icon support #10

faiface opened this issue Apr 30, 2017 · 2 comments
Labels
Milestone

Comments

@faiface
Copy link
Owner

faiface commented Apr 30, 2017

Add a *pixelgl.Window method to set the icon of the window. The icon is usually displayed at the top bar of the window, or in the task bar of the desktop environment.

  • (*pixelgl.Window).SetIcon(pixel.Picture) - sets the icon of the window to the given picture

I don't think a getter is necessary.

Also, make it possible to add an icon to pixelgl.WindowConfig by adding a Icon field there. Is the (*pixelgl.Window).SetIcon actually necessary with this field?

@faiface faiface added this to the v0.6 milestone Apr 30, 2017
@otraore
Copy link
Contributor

otraore commented Apr 30, 2017

For most users, it probably wouldn't be necessary to have a SetIcon method but in some use cases, it might be useful. For example updating the icon to update the status of the game or something.

@faiface
Copy link
Owner Author

faiface commented Apr 30, 2017

Yes, I also don't find that method to be particularly useful. It might be a good idea to leave it out, in order to avoid feature blow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants