Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests] Fail immediately if any chart fails the e2e tests #343

Closed
rbren opened this issue Aug 17, 2020 · 2 comments
Closed

[tests] Fail immediately if any chart fails the e2e tests #343

rbren opened this issue Aug 17, 2020 · 2 comments
Labels
automation Pertains to the CI/CD process surrounding this repo, not a particular chart. enhancement Adding additional functionality or improvements wontfix This will not be worked on

Comments

@rbren
Copy link
Contributor

rbren commented Aug 17, 2020

Is your feature request related to a problem? Please describe.
When I change multiple charts, and one of them fails, the tests still continue for each changed chart

Describe the solution you'd like
Fail immediately

Describe alternatives you've considered

Additional context
Most of our PRs are just one chart, so not a huge deal, but larger PRs are a pain to debug, as you have to scroll through heaps of CircleCI logs
@rbren rbren added the enhancement Adding additional functionality or improvements label Aug 17, 2020
@sudermanjr sudermanjr changed the title [tests] Fail immediately if any chart fails the e2d tests [tests] Fail immediately if any chart fails the e2e tests Aug 17, 2020
@sudermanjr
Copy link
Member

This is the repo we use https://github.com/helm/chart-testing/tree/master/ct/cmd

I don't see an option to fail fast or anything like that.

@sudermanjr sudermanjr added the automation Pertains to the CI/CD process surrounding this repo, not a particular chart. label Oct 13, 2020
@sudermanjr
Copy link
Member

Would prefer to see this completed instead. helm/chart-testing#282

Can't really do this in current configuration

@sudermanjr sudermanjr added the wontfix This will not be worked on label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
automation Pertains to the CI/CD process surrounding this repo, not a particular chart. enhancement Adding additional functionality or improvements wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rbren @sudermanjr